Thread: Simple Parabolic SAR EA

I have been following this ea for a while now.

Its freely available from Pip Cop - Forex Robot Reviews. Very nice site that forward tests ea on live and demo.

This ea works on eurusd 30 min. It places short (sell) trades only. It appears that longs (buy) do not work well.

I tried it with my FXDD broker but the results were poor. Maybe this ea is broker specific or time specific.

I decided to try it on eurjpy and I had better results.

I tried to filter out the bad trades by only taking sell candles and I tried to stop reverses by closing trades that closed with a buy candle above an EMA 3 on the 15 chart.

I'm not much of a coder. I don't think the EMA3 is in the correct part of code to stop bad trade.

I think I am on the right track with this ea. If the trade is going to go in our favor it seems to happen very quickly. By the same token if it goes against us it also happens quickly.

I messed around with the trailing stop amount, I think that might have cut my profits.

A better way might be to take stepped profit to lock in pips.
Maybe up 15 pips lock 3, up 25 lock 10, up 30 lock 15, or something like that.

I also noticed that ea makes multiple trades in the same candle. Might be better to take one or two profit from candle and wait for next trade setup.

Please ignore the eurusd trades in statement. At first glance the statement may not look good, If we can find a way to cut losses quickly, you can see that you had more winners than loosers.

I have included the original code, my modified code, and my current forward statement.

I also added in a mixed statement that has several ea's in it when I was doing my initial tests. Just ignore everything and concentrate on the macd sample ones (thats actually the parabolic sar).

Thanks for sharing these codes,

What do you want to do exactly ?

Originally Posted by funyoo

Thanks for sharing these codes,

What do you want to do exactly ?

I think the following items would improve the profits and get you out of bad trades quicker.

1. Filter bad trades by closing trade when a candle closes above a EMA 3 on the 15 chart. Can you check to see if I have done this correctly?

2. Add a stepped profit to lock in pips.
Trade up 15 pips move SL to in lock 3 pips, up 25 lock 10, up 30 lock 15, or something like that. User should be able to adjust values for best profit.

3. Have setting to limit amount of trades it opens when conditions are met. I noticed it opens several trades during candle open, especially if trailing stop is a low value (around 9). It would hit TS and then open another trade because candle is still not formed and trade conditions are still met.

4. Add a method to close trade after X number of candles. The idea on this is if trade is open it should go into profit fairly quickly (within 5 bars) on a lower time frame. If it does not then it usually reverses so we should close quickly.

5. Be able to trade by tick mode or by closed candle mode.

Thanks

Originally Posted by EvertonHarding

1. Filter bad trades by closing trade when a candle closes above a EMA 3 on the 15 chart. Can you check to see if I have done this correctly?

You have forgotten the parenthesis here :

if( (SARCurrent<Bid && SARPrevious>Bid) ||(Close[1] > Filter))

Note that it will generate some conflicts.

Originally Posted by EvertonHarding

2. Add a stepped profit to lock in pips.
Trade up 15 pips move SL to in lock 3 pips, up 25 lock 10, up 30 lock 15, or something like that. User should be able to adjust values for best profit.

I suggest you to create a function for this :

Code:

void ModSL(double ldSL){bool fm;fm=OrderModify(OrderTicket(),OrderOpenPrice(),ldSL,OrderTakeProfit(),0,CLR_NONE);}

then to create the conditions, if ((Bid-OrderOpenPrice())>=X*Point)ModSL(Bid-(X-Y)*Point);

Etc...

Originally Posted by EvertonHarding

3. Have setting to limit amount of trades it opens when conditions are met. I noticed it opens several trades during candle open, especially if trailing stop is a low value (around 9). It would hit TS and then open another trade because candle is still not formed and trade conditions are still met.

See here to limit the number of trades : http://www.tradingsystemforex.com/mq...each-tick.html

Originally Posted by EvertonHarding

4. Add a method to close trade after X number of candles. The idea on this is if trade is open it should go into profit fairly quickly (within 5 bars) on a lower time frame. If it does not then it usually reverses so we should close quickly.

You have to study the datetime, when an order is generated you set a value to a datetime parameter. For example.

datetime dateorder;

...

OrderSend(....);dateorder=CurTime();

if((CurTime()-dateorder)>=X)OrderClose(..);

Originally Posted by EvertonHarding

5. Be able to trade by tick mode or by closed candle mode.

See the trenchaser supernova code for that.

I have not enough time to modify the code of everybody. I suggest you to do it yourself for your education, also as it is your own template.