Thread: Take Profit Increment - Help please

I have the following code, but it is not working, please help to correct it, thanks in advance.

void TPI()
{
int cnt,total=OrdersTotal();
for(cnt=0;cnt<total;cnt++)
{
OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
if(OrderType()<=OP_SELL&&OrderSymbol()==Symbol()&& OrderMagicNumber()==Magic)
{
if(OrderType()==OP_BUY)
{
if((Bid-OrderOpenPrice())/(point*digits)>=20) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()+10*point,digits),OrderTa keProfit(),0,Blue);
if((Bid-OrderOpenPrice())/(point*digits)>=30) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()+15*point,digits),OrderTa keProfit(),0,Blue);
if((Bid-OrderOpenPrice())/(point*digits)>=40) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()+25*point,digits),OrderTa keProfit(),0,Blue);
if((Bid-OrderOpenPrice())/(point*digits)>=50) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()+35*point,digits),OrderTa keProfit(),0,Blue);
if((Bid-OrderOpenPrice())/(point*digits)>=60) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()+45*point,digits),OrderTa keProfit(),0,Blue);
if((Bid-OrderOpenPrice())/(point*digits)>=70) TrailingStop=15;
return(0);
}
else
{
if((OrderOpenPrice()-Ask)/(point*digits)>=20) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()-10*point,digits),OrderTakeProfit(),0,Red);
if((OrderOpenPrice()-Ask)/(point*digits)>=30) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()-15*point,digits),OrderTakeProfit(),0,Red);
if((OrderOpenPrice()-Ask)/(point*digits)>=40) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()-25*point,digits),OrderTakeProfit(),0,Red);
if((OrderOpenPrice()-Ask)/(point*digits)>=50) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()-35*point,digits),OrderTakeProfit(),0,Red);
if((OrderOpenPrice()-Ask)/(point*digits)>=60) OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(OrderOpenPrice()-45*point,digits),OrderTakeProfit(),0,Red);
if((OrderOpenPrice()-Ask)/(point*digits)>=70) TrailingStop=15;
return(0);
}
}
}
}

Originally Posted by jezzer1961

What is "digits" and why have you added it to the condition lines? This now does not make sense unless you have defined it correctly elsewhere.

Why also do you need to hop to another function (MoveTrailingStop())? This element can be done from within the existing function as I have shown.

// Broker digit function
if(Digits<4)
{
point=0.01;
digits=2;
}
else
{
point=0.0001;
digits=4;
}


return(0);
}

void MoveTrailingStop()
{
int cnt,total=OrdersTotal();
for(cnt=0;cnt<total;cnt++)
{
OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
if(OrderType()<=OP_SELL&&OrderSymbol()==Symbol()&& OrderMagicNumber()==Magic)
{
if(OrderType()==OP_BUY)
{
if(TrailingStop>0&&Ask>NormalizeDouble(OrderOpenPr ice()+TrailingProfit*point,digits))
{
if((NormalizeDouble(OrderStopLoss(),digits)<Normal izeDouble(Bid-point*(TrailingStop+TrailingStep),digits))||(Order StopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(Bid-point*TrailingStop,digits),OrderTakeProfit(),0,Blu e);
return(0);
}
}
}
else
{
if(TrailingStop>0&&Bid<NormalizeDouble(OrderOpenPr ice()-TrailingProfit*point,digits))
{
if((NormalizeDouble(OrderStopLoss(),digits)>(Norma lizeDouble(Ask+point*(TrailingStop+TrailingStep),d igits)))||(OrderStopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Normali zeDouble(Ask+point*TrailingStop,digits),OrderTakeP rofit(),0,Red);
return(0);
}
}
}
}
}
}

Can you understand now?

Hey szmvscla,

Not to be rude but I have been trying to do the exact stepping stop function, as you may have seen on another post of mine.....(without success). I wanted to be able to put all my profit/step amounts in the 'extern int = ' for easy management of changing values, but I cant code to save my life.
Could you post any global varriable/int start..etc code that goes with your above code so that I might be able to try to get it to work for me.

If not thanks anyway and Trade Well.

Dono

Originally Posted by jezzer1961

Firstly, does the EA compile with and without the code for the stop-loss function added? I find that when I type blocks of code into a message box on a forum, I frequently make syntax errors (maybe a typo or missing semi-colon or an odd number of brackets). If I had used MetaEditor, I would have seen straight away that it didn't compile, but typing straight into a message box is obviously different. I then read back through the thread at a later date and find myself editing errors that I've made.

On the basis that it compiles OK, are you calling the function from the appropriate place in the loop? If you are using a stop-loss system like this, you will need to call the function from towards the top of the start() function so that the stop-loss is re-calculated with every incoming tick. With other types of variable stop-loss, it may only be necessary to adjust the stop at new bar open, in which case you would call the function from a different part of the loop.

Finally, if it still doesn't work, you will need to paste or attach the whole EA so that somebody can debug it.

So, please, if you can take a the code, the EA is attached. Thanks in advance!

Originally Posted by Dono

Hey szmvscla,

Not to be rude but I have been trying to do the exact stepping stop function, as you may have seen on another post of mine.....(without success). I wanted to be able to put all my profit/step amounts in the 'extern int = ' for easy management of changing values, but I cant code to save my life.
Could you post any global varriable/int start..etc code that goes with your above code so that I might be able to try to get it to work for me.

If not thanks anyway and Trade Well.

Dono

I am sorry, but my code is not working too, let's wait for our friend Jeezer to check it if possible.