Thread: Basket Profit/Loss Bug

Hi! I was testing the Basket Profit/Loss function and I found a bug.

Example:

Profit=10
Loss=5

When one of the those levels is reached the EA doesn't close all the traders, if you know how to correct it, please let me know, above you can check the code that I am using.

extern bool UseProfitLoss=true;
extern int BasketProfit=50;
extern int BasketLoss=100;

//Basket Profit/Loss
if(UseProfitLoss)
{
CurrentBasket=AccountEquity()-AccountBalance();
if(CurrentBasket >= BasketProfit || CurrentBasket <= (BasketLoss*(-1)))
{
NewOrders=false;
CloseSellOrders(Magic);
CloseBuyOrders(Magic);
return(0);
}
}

Thanks in advance!

Originally Posted by jezzer1961

Without seeing what happens inside the CloseSellOrders() and CloseBuyOrders() functions, it is impossible to see what exactly is wrong.

You must ensure that these two function close all open orders before passing control back to the originating function. If they return control back before everything is closed, then the close conditions will no longer be met and the EA will have no reason to close any of the remaining orders.

Thanks for reply and help! I found a very good Basket Profit/Loss code and , I am attaching an "EA" without any signal condition just for the people who need this function can take look at the code.

Copyrights: I got the code of this "EA" from here and the Basket code here: Multi-purpose trade management ea @ Forex Factory *- I just changed very small things in the code.

*I don't know if I can post a link from another forum, but if the admin doesn't allow it, please remove it.